[FFmpeg-devel] [PATCH] Added support for MB_INFO

[Carotti, Elias]

Hi,
thanks for pointing out the printf. That's a left over which I removed.

I am not clear on the possible leak you are hinting at. 
The new side information only passes two pointers to libx264, the first
one being a buffer with the flags and a pointer to a deallocator which
may be NULL. 

If the deallocator is not NULL libx264 we're yielding the deallocation
responsibility to libx264, otherwise the ownership of the buffer and,
as such, the responsibility for the deallocation remains with the
caller. 
As such, the only possibility for a leak seems to me due to a
programming error.
Is that what you were asking or am I missing something else?

Please find attached the updated patch.

Elias



On Fri, 2022-06-17 at 11:40 +0200, Timo Rothenpieler wrote:
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender
> and know the content is safe.
> 
> 
> 
> On 17.06.2022 10:41, Carotti, Elias wrote:
> > Hi all,
> > any chance someone could possibly have a look at this patch,
> > please?
> > Thanks in advance
> > 
> > 
> > 
> > On Fri, 2022-06-10 at 10:11 +0000, Carotti, Elias wrote:
> > > Hi,
> > > patch attached to add support for passing down to libx264
> > > information
> > > about which macroblock could be eligible for being coded as
> > > P_SKIP.
> > > 
> > 
> > 
> > NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro
> > delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale
> > Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052,
> > Societa con Socio Unico
> > 
> 
> There's a stray printf in the patch.
> 
> Also, what if a frame with such side data is passed to not-x264?
> Won't
> it leak the memory?
>  From the looks if it, this entirely relies on x264 to free it.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-support-for-MB_INFO.patch
Type: text/x-patch
Size: 9837 bytes
Desc: 0001-Added-support-for-MB_INFO.patch
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220617/3547101c/attachment.bin>