[FFmpeg-devel] [PATCH 0/6 v2] avformat/movenc: normalize on AC-3 parser usage

Jan Ekström jeebjp at gmail.com
Mon Jun 20 10:19:20 EEST 2022


On Fri, Jun 17, 2022 at 4:04 PM Jan Ekström <jeebjp at gmail.com> wrote:
>
> The simplified parsing currently in `mov_write_ac3_tag` trusts the content
> of the packets a bit too much (the AC-3 parser returns all data fed to it,
> including any possible data before the start code), while the existing E-AC-3
> logic does proper header validation by utilizing the (E-)AC-3 parser.
>
> Thus, normalize on AC-3 parser usage for both AC-3 and E-AC-3.
>
> Difference to v1:
> * Instead of expanding the avpriv parser interface, make the bit rate table
>   available to libavformat as well as libavcodec. This also theoretically
>   allows the calculation based on data rate, thus allowing the correct
>   bit rate to be signaled with bsids 9 and 10, which have their effective
>   bit rate and sample rate values divided by 2 and 4 respectively.
>

I will move towards pulling this patch set in tomorrow unless there
are objections. The earlier version of this patch set has been
successfully working in various locations, and the effective result
from this version of the patch set seems to be the same.

Jan


More information about the ffmpeg-devel mailing list