[FFmpeg-devel] [PATCH] avformat/matroskaenc: Fix use of uninitialized value

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Jun 26 07:20:17 EEST 2022


Regression since 67eea6cf026a70940ea402d54685d67c660b49cd.
Affects only WebVTT when muxing WebM. (This is covered
by the webm-webvtt-remux FATE test which fails for several
FATE boxes on fate-ffmpeg.org.)

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
I tested with Valgrind before 67eea6cf026a70940ea402d54685d67c660b49cd
and it didn't fail. It only fails on -O0; Disabling stack reuse
is not enough to make it fail.
Anyway, will apply this soon.

 libavformat/matroskaenc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 4f5afc1be4..1256bdfe36 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -1914,6 +1914,7 @@ static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv,
     }
 
     end_ebml_master(pb, track_master);
+    ret = 0;
 fail:
     ffio_reset_dyn_buf(mkv->tmp_bc);
 
-- 
2.34.1



More information about the ffmpeg-devel mailing list