[FFmpeg-devel] [PATCH] fix build, avcodec: update OpenH264 header path

[Daniel Pocock]

On 01/03/2022 10:19, Hendrik Leppkes wrote:
> On Tue, Mar 1, 2022 at 9:16 AM Daniel Pocock <daniel at pocock.pro> wrote:
>>
>>
>> This updates the locations searched for the OpenH264 headers to be
>> consistent with upstream
>>
>> Discussed here:
>> https://github.com/cisco/openh264/pull/3415
>>
>> Due to the change in the pkgconfig file, it is possible to compile with
>> either:
>>
>>   #include <openh264/codec_api.h>
>>
>> OR
>>
>>   #include <codec_api.h>
>>
>> but in this patch, I used the former.
>>
> 
> Which releases of the library have the updated location? Will older
> releases still work, if so, which?

This patch is very trivial and doesn't attempt to support older releases
of OpenH264.  Please keep in mind the OpenH264 code is patented and not
widely installed in Linux distributions.  Developers have to download it
directly each time they include it in a project.  So there doesn't
appear to be a compelling case to support many versions concurrently.

> As far as I can see, the change is days old and not in any release, so
> committing this now would break compatibility with anything but
> OpenH264 git master? Is that correct?

Yes, that is correct

Jeff made a comment in Github about this change breaking the ffmpeg
build.  I don't know which combination of ffmpeg and OpenH264 he is
aiming to build.

It would be a good idea to commit in ffmpeg whenever OpenH264 makes
another tag.  Their last tag was v2.2.0 on 28 January and the next one
will eventually appear on this page:
https://github.com/cisco/openh264/tags

Regards,

Daniel

-- 
Debian Developer
https://danielpocock.com