[FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag

Hendrik Leppkes h.leppkes at gmail.com
Sun May 1 18:53:38 EEST 2022


On Sun, May 1, 2022 at 5:48 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>
> On Sun, May 1, 2022 at 7:09 AM Soft Works <softworkz at hotmail.com> wrote:
> > I think that's what Hendrik wanted to point out as far as I understood.
> >
>
> Basically, I want explicit behavior, not implicit defaults. Anytime a
> hwcontext is created, something should tell it what its going to be
> used for, so we can determine which flags make sense (or ideally, it
> should just specify the flags).
>
> This patch creates an implicit default for one use-case, is this going
> to work with all others? No, of course not, because it has to know
> what flags to set. Thats why explicitly setting those flags is
> important, instead of just fixing one implicit case.
>

On that note, the example commandline it fixes just does hwupload and
nothing else - does that even require render target to be flagged?
>From what I can tell it uses a simple
ID3D11DeviceContext::CopySubresourceRegion to copy from the staging
texture, which should not require any particular bind flags. Bind
Flags in turn would then depend on what you are actually trying to do
with the texture (shader input, etc), in this example... nothing?

- Hendrik


More information about the ffmpeg-devel mailing list