[FFmpeg-devel] [PATCH] fftools/opt_common: add missing include of avf/version.h

[Andreas Rheinhardt]

softworkz:
> From: softworkz <softworkz at hotmail.com>
> 
> required for PRINT_LIB_INFO(avfilter...
> 
> Signed-off-by: softworkz <softworkz at hotmail.com>
> ---
>     fftools/opt_common: add missing include of avf/version.h
>     
>     MSVC compiler complains without this include
> 
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-27%2Fsoftworkz%2Fsubmit_version_include-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-27/softworkz/submit_version_include-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/27
> 
>  fftools/opt_common.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index c303db4d09..5a5e35bd7f 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -51,6 +51,8 @@
>  #include "libavdevice/avdevice.h"
>  #include "libavdevice/version.h"
>  
> +#include "libavfilter/version.h"
> +
>  #include "libswscale/swscale.h"
>  #include "libswscale/version.h"
>  
> 
> base-commit: d2d8b9b972ba2df6b2a2ebe29f5307cbb7a69c33

What does "complain" here mean? Compilation failure?
It should already be included via
opt_common.h->cmdutils.h->avfilter.h->lavfi/version.h. The latter
inclusion relies on HAVE_AV_CONFIG_H to not be defined. It should only
be defined for the libraries, not fftools, so if it is defined for you
for this file your setup is wrong.
That being said it is nevertheless good to include this and avfilter.h
directly.

- Andreas