[FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Derek Buitenhuis
> Sent: Friday, May 20, 2022 2:50 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define
> X264_API_IMPORTS when compiling static
> 
> On 5/20/2022 1:07 PM, Soft Works wrote:
> > I'm working with regular Visual Studio projects, though.
> > Even dependencies like libx264 are compiled in their own
> > VS projects.
> > There's no MSYS2, no make, no pkg-conf involved.
> 
> Things should not be added to FFmpeg in support of
> non-standard build systems.
> 
> As per Thilo's explanation, I think this is a more appropraite fix:
> 
>     http://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html
> 
> Matt sent that last October, but it seems to have been missed.

Actually I had talked to Matt about it and he gave me permission to 
rebase and resubmit his patch. (due to lack of time)

But here comes my dilemma: I can't submit something which I'm not 
working with usually and where I don't have sufficient experience 
to be confident that it's all well.

There have ben several discussions about it last year, last one 
with Michael in December IIRC. 
I wouldn't be able to go through defending and evolving this patch,
that's why I wanted to do something very very basic and simple.


Kind regards,
softworkz