[FFmpeg-devel] [PATCH] avformat/movenc: Remove experimental status of TrueHD-in-MP4 muxing (mlpa)

[James Almer]

On 11/6/2022 6:40 PM, Nomis101 wrote:
> Am 05.11.22 um 21:31 schrieb Nomis101:
>> Support for mlpa muxing was added back in 2019: 
>> http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=808a6717e0c584738c60a109afd6d47f4973d619
>> But it was hidden back then behind FF_COMPLIANCE_EXPERIMENTAL, because 
>> it was new and there was no support from other applications.
>>
>> In the meantime there is support in MediaInfo: 
>> MediaArea/MediaInfoLib#1258
>> 
For VLC: videolan/vlc at 9c49f40

>> Since version 7.3.4 for Infuse: 
>> https://community.firecore.com/t/dolby-mlp-mlpa-codec-support/26100/31
>> And mpv does support this as well.
>> So, there is no need anymore to hide this behind 
>> FF_COMPLIANCE_EXPERIMENTAL. Also, it should be the user's 
>> responsibility to choose this only if the user's software/hardware 
>> supports it.
>> Therefore, this patch removes the experimental status of TrueHD-in-MP4 
>> muxing.
>>
>> Signed-off-by: Nomis101 <Nomis101 at web.de>
>> ---
>>   libavformat/movenc.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
>> index 754f95912a..50f1831860 100644
>> --- a/libavformat/movenc.c
>> +++ b/libavformat/movenc.c
>> @@ -7157,7 +7157,6 @@ static int mov_init(AVFormatContext *s)
>>                   }
>>               }
>>               if (track->par->codec_id == AV_CODEC_ID_FLAC ||
>> -                track->par->codec_id == AV_CODEC_ID_TRUEHD ||
>>                   track->par->codec_id == AV_CODEC_ID_OPUS) {
>>                   if (track->mode != MODE_MP4) {
>>                       av_log(s, AV_LOG_ERROR, "%s only supported in 
>> MP4.\n", avcodec_get_name(track->par->codec_id));
> 
> 
> Hi all. Patchwork does say something about "Failed to apply patch". Is 
> this somehing I should worry about? And if yes, how to fix it? It has 
> been properly generated using git format-patch.

Did you make the patch on top of latest git head (master branch)? It 
definitely doesn't apply as is.