[FFmpeg-devel] [PATCH 14/20] fftools/ffmpeg_mux_init: drop a duplicated block in copy_metadata()

[Anton Khirnov]

Quoting Michael Niedermayer (2022-10-18 23:51:22)
> On Tue, Oct 18, 2022 at 02:36:55PM +0200, Anton Khirnov wrote:
> > It does the same thing as the block right below it.
> > ---
> >  fftools/ffmpeg_mux_init.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> 
> This seems to make a difference for
> ffmpeg -i meta.flac -map_metadata:s -1 -vcodec mpeg4 -t 0.1  -y /tmp/tmp3x.mkv
> 
> The metadata in meta.flac is a bit odd though
> 
> Input #0, flac, from '/home/michael/videos/meta.flac':
>   Metadata:
>     al              : Hyper fast Audio and Video encoder
>                     : usage: ffmpeg [options] [[infile options] -i infile]... {[outfile options] outfile}...
>                     : 
>                     : Main options:
> ....
>                     : -param1            <double> E.V.. scaler param 1
>     x               : öäü?ß^x²€

Is this before or after?

If I'm reading the code correctly, no metadata should be copied after my
patch, which IMO is more consistent with the docs.

-- 
Anton Khirnov