[FFmpeg-devel] [PATCH 2/5] lavf/demux: treat EAGAIN as REDO unless AVFMT_FLAG_NONBLOCK is set

[Anton Khirnov]

Quoting Paul B Mahol (2022-11-10 13:52:52)
> On 11/10/22, Anton Khirnov <anton at khirnov.net> wrote:
> > Quoting Michael Niedermayer (2022-11-10 13:28:27)
> >> On Tue, Nov 08, 2022 at 12:25:47PM +0100, Anton Khirnov wrote:
> >> > Lavf only supports a very limited approximation of non-blocking
> >> > behavior, so we should not return random EAGAINs to callers unless they
> >> > specifically requested it.
> >> > ---
> >> >  libavformat/demux.c | 8 ++++++--
> >> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >>
> >> this changes seeking behavior of for example:
> >> libavformat/tests/seek fate-suite/dss/sp.dss
> >>
> >> (this seemed to return EAGAIN before sometimes)
> >
> > Are you saying that is wrong? I don't see why seeks should return EAGAIN
> > either.
> >
> 
> It returns internally when passing seeking to generic seeking.
> Please  do not break seeking in demuxers.

What exact use case is being broken by this?

-- 
Anton Khirnov