[FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes

Oneric oneric at oneric.de
Sun Nov 13 21:57:15 EET 2022


This fixes colours and font selection for files converted to ASS

v2
==

On Nicolas George’s request resent with plain text diff for the updated
refernce files. There is no other change and applying the diff of v1
yields equal results to v2.

Those files do intentionally contain CRLF line endings,
but apart from tests/ref/fate/sub-scc they are not marked as
"diff eol=crlf" in .gitattributes, so the diff (intentionally) contains
some CRLF lines as well. Patchwork has or at least used to have bugs
dealing with CRLF diffs. In particular it may wrongly fail to apply the
patch (I believe this is fixed by now though) and the buttons
for downloading the diff or pasting it into the clipboard corrupt line
endings making the diff useless.
Instead directly apply the email in your inbox or use patchwork’s mbox
download. If your git is configured strictly, you may also need to use
git am --keep-cr ... . (Or just apply v1)

v1
==

Original version sent using binary diffs for reference files.


Oneric (3):
  avcodec/ass: fix comment
  avcodec/ass: accurately preserve colours
  avcodec/ass: specify a permissive encoding

 libavcodec/ass.c                 | 5 +++--
 tests/ref/fate/sub-aqtitle       | 3 ++-
 tests/ref/fate/sub-cc            | 3 ++-
 tests/ref/fate/sub-cc-realtime   | 3 ++-
 tests/ref/fate/sub-cc-scte20     | 3 ++-
 tests/ref/fate/sub-charenc       | 3 ++-
 tests/ref/fate/sub-jacosub       | 3 ++-
 tests/ref/fate/sub-microdvd      | 3 ++-
 tests/ref/fate/sub-movtext       | 3 ++-
 tests/ref/fate/sub-mpl2          | 3 ++-
 tests/ref/fate/sub-mpsub         | 3 ++-
 tests/ref/fate/sub-mpsub-frames  | 3 ++-
 tests/ref/fate/sub-pjs           | 3 ++-
 tests/ref/fate/sub-realtext      | 3 ++-
 tests/ref/fate/sub-sami          | 3 ++-
 tests/ref/fate/sub-sami2         | 3 ++-
 tests/ref/fate/sub-scc           | 3 ++-
 tests/ref/fate/sub-srt           | 3 ++-
 tests/ref/fate/sub-srt-badsyntax | 3 ++-
 tests/ref/fate/sub-stl           | 3 ++-
 tests/ref/fate/sub-subviewer     | 3 ++-
 tests/ref/fate/sub-subviewer1    | 3 ++-
 tests/ref/fate/sub-vplayer       | 3 ++-
 tests/ref/fate/sub-webvtt        | 3 ++-
 tests/ref/fate/sub-webvtt2       | 3 ++-
 25 files changed, 51 insertions(+), 26 deletions(-)

-- 
2.30.2



More information about the ffmpeg-devel mailing list