[FFmpeg-devel] [PATCH v2 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM

[L. E. Segovia]

Hi,

I preferred to check instead for HAVE_X86ASM, as those checks would only
hit on either a missing or crippled NASM. Moreover, the EXTERNAL_<arch>
macros do both the HAVE_<arch>_EXTERNAL  and the runtime CPU flag check.
The former of which would become redundant and duplicated with your
suggestion.

Should I move forward anyway with it?

On 03/11/2022 12:55, dev at lynne.ee (Lynne) wrote:
> Nov 3, 2022, 16:30 by amy at amyspark.me:
> 
>> Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a
>>
>> Signed-off-by: L. E. Segovia <> amy at amyspark.me> >
>>
> 
> Wrong way to fix it. Makefile to prevent compilation + ifdef guards
> on all arch-specific init function calls.
> 

-- 
amyspark 🌸 https://www.amyspark.me