[FFmpeg-devel] [PATCH 4/4] doc/developer.texi: refine the "contributing code" section

Anton Khirnov anton at khirnov.net
Mon Nov 14 11:13:09 EET 2022


Drop the reference to directly committing code, because
- it is highly discouraged and very rarely done these days
- there is no good reason NOT to submit patches for review

Add a link to the development policy chapter.
---
 doc/developer.texi | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/doc/developer.texi b/doc/developer.texi
index 2e050edc6a..cf918ac6b1 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -46,15 +46,10 @@ consult @url{https://ffmpeg.org/legal.html}.
 
 @section Contributing code
 
-There are 2 ways by which code gets into FFmpeg:
- at itemize @bullet
- at item Submitting patches to the ffmpeg-devel mailing list.
-      See @ref{Submitting patches} for details.
- at item Directly committing changes to the main tree.
- at end itemize
-
-Whichever way, changes should be reviewed by the maintainer of the code
-before they are committed. And they should follow the @ref{Coding Rules}.
+All proposed code changes should be submitted for review to
+ at url{mailto:ffmpeg-devel@@ffmpeg.org, the development mailing list}, as
+described in more detail in the @ref{Submitting patches} chapter. The code
+should comply with the @ref{Development Policy} and follow the @ref{Coding Rules}.
 The developer making the commit and the author are responsible for their changes
 and should try to fix issues their commit causes.
 
@@ -267,6 +262,7 @@ For Emacs, add these roughly equivalent lines to your @file{.emacs.d/init.el}:
 (setq c-default-style "ffmpeg")
 @end lisp
 
+ at anchor{Development Policy}
 @chapter Development Policy
 
 @section Patches/Committing
-- 
2.35.1



More information about the ffmpeg-devel mailing list