[FFmpeg-devel] [PATCH v2] avcodec/tiff: add read support for compressed rgb floating point formats
Anton Khirnov
anton at khirnov.net
Mon Nov 14 18:50:37 EET 2022
Quoting mindmark at gmail.com (2022-10-02 01:05:12)
> From: Mark Reid <mindmark at gmail.com>
>
> floating point uses a slightly different predictor technique describe here
> http://chriscox.org/TIFFTN3d1.pdf
>
> Here is a link the test files, if someone could add them to fate me
> https://www.dropbox.com/s/fg59h2os4gb4wug/tiff_fate_samples.zip
>
>
> ---
> libavcodec/tiff.c | 68 ++++++++++++++++++++++
> tests/fate/image.mak | 20 ++++++-
> tests/ref/fate/tiff-lzw-rgbaf32le | 6 ++
> tests/ref/fate/tiff-lzw-rgbf32le | 6 ++
> tests/ref/fate/tiff-uncompressed-rgbaf32le | 6 ++
> tests/ref/fate/tiff-uncompressed-rgbf32le | 6 ++
> tests/ref/fate/tiff-zip-rgbaf32le | 6 ++
> tests/ref/fate/tiff-zip-rgbf32le | 6 ++
> 8 files changed, 123 insertions(+), 1 deletion(-)
> create mode 100644 tests/ref/fate/tiff-lzw-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-lzw-rgbf32le
> create mode 100644 tests/ref/fate/tiff-uncompressed-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-uncompressed-rgbf32le
> create mode 100644 tests/ref/fate/tiff-zip-rgbaf32le
> create mode 100644 tests/ref/fate/tiff-zip-rgbf32le
Looks acceptable, will push in a few days if nobody objects.
But decode_frame() is starting to look very long and smelly and could
definitely use some refactoring.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list