[FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: add direct film grain mode
Lynne
dev at lynne.ee
Tue Nov 22 00:03:19 EET 2022
Nov 21, 2022, 20:50 by ruijing.dong at amd.com:
> Add flag AV_VAAPI_DRIVER_QUIRK_DIRCT_FILM_GRAIN_ATTRIBUTES to
> specify a direct film grain mode for AMD av1 decoder.
>
> issue:
> By using AMD av1 decoder via VAAPI, when used with film
> grain content, the output displays black screen with
> incorrect frame order.
>
> The issue being discussed in here:
> https://gitlab.freedesktop.org/mesa/mesa/-/issues/6903#note_1613807
>
> Signed-off-by: Ruijing Dong <ruijing.dong at amd.com>
> Signed-off-by: nyanmisaka <nst799610810 at gmail.com>
> ---
>
> update: using driver_quirks to identify AMD driver instead of
> extra AV_HWACCEL_FLAG.
>
> libavcodec/avcodec.h | 1 -
> libavcodec/vaapi_av1.c | 6 ++++--
> libavutil/hwcontext_vaapi.c | 5 +++++
> libavutil/hwcontext_vaapi.h | 6 ++++++
> 4 files changed, 15 insertions(+), 3 deletions(-)
>
I think this looks fine. Just needs a micro bump and APIchanges,
but whoever commits it can apply that.
jkqxz should take a look at it too.
More information about the ffmpeg-devel
mailing list