[FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper type for NALU type

[Soft Works]

> -----Original Message-----
> From: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> Sent: Wednesday, November 23, 2022 4:20 AM
> To: Soft Works <softworkz at hotmail.com>; FFmpeg development
> discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use
> proper type for NALU type
> 
> Soft Works:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> >> Andreas Rheinhardt
> >> Sent: Sunday, July 3, 2022 12:21 AM
> >> To: ffmpeg-devel at ffmpeg.org
> >> Cc: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> >> Subject: [FFmpeg-devel] [PATCH 01/20] avcodec/hevc_sei: Use proper
> >> type for NALU type
> >>
> >> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> >> ---
> >
> > Nice! That's helpful for the QSV SEI parsing. The one missing bit
> > is the HDR data (AVMasteringDisplayMetadata and
> AVContentLightMetadata)
> > assignment which still seems to remain in hevcdec. Would it make
> sense
> > for factor this out as well?
> >
> 
> While the H.264 and HEVC syntax and semantics for these coincide, the
> HEVC implementation of it is not completely spec-compliant with
> respect
> to its persistency: The persistence ends when the coded video
> sequence
> ends and if the new coded video sequence does not have these SEIs,
> then
> we would need to attach an AVMasteringDisplayMetadata and/or
> AVContentLightMetadata just to cancel the earlier values. I just
> don't
> want to enter this and this includes not extending it to H.264.
> Anyway, I have now rebased this patchset on top of master:
> https://github.com/mkver/FFmpeg/tree/h2645_sei (with no noteworthy
> conflicts; basically the only change is that the second to last
> commit
> now adds proper newlines to the newly created files). I intend to
> apply
> it in two days unless there are objections.
> 
> - Andreas


Hi,

I'm not sure whether you seen the patchset I had submitted 
meanwhile? It doesn't go as far as yours in a way that I didn't 
try to merge H264/5 functionality, but now it consequently splits
out the bits that are meant for common use.
I was able to eliminate all those makefile dependencies which you
had criticized (for valid reasons).

I hadn't seen any hint from you whether you are intending to 
proceed with your patchset, that's why I didn't know whether 
I should have waited. But I don't mind when you apply yours 
now, I will look into it and adapt.

Maybe you find the time to take only a quick look and let me 
know whether this goes into the right direction?
https://github.com/ffstaging/FFmpeg/pull/31/files

Thanks,
softworkz