[FFmpeg-devel] [PATCH v2 4/5] avcodec/x86/v210enc: expand and correct comments

James Darnley jdarnley at obe.tv
Fri Nov 25 17:17:19 EET 2022


---
 libavcodec/x86/v210enc.asm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/x86/v210enc.asm b/libavcodec/x86/v210enc.asm
index 552164a8be..d3639cd440 100644
--- a/libavcodec/x86/v210enc.asm
+++ b/libavcodec/x86/v210enc.asm
@@ -314,7 +314,7 @@ cglobal v210_planar_pack_8, 5, 5, 7+notcpuflag(avx512icl), y, u, v, dst, width
             movu         ym1, [yq + 2*widthq]
             vinserti32x4  m1, [uq + 1*widthq], 2
             vinserti32x4  m1, [vq + 1*widthq], 3
-            vpermb        m1, m2, m1                 ; uyv0 yuy0 vyu0 yvy0
+            vpermb        m1, m2, m1                 ; uyvx yuyx vyux yvyx
         %else
             movq         xm0, [uq + 1*widthq]        ; uuuu uuxx
             movq         xm1, [vq + 1*widthq]        ; vvvv vvxx
@@ -325,10 +325,10 @@ cglobal v210_planar_pack_8, 5, 5, 7+notcpuflag(avx512icl), y, u, v, dst, width
         %endif
         CLIPUB       m1, m4, m5
 
-        pmaddubsw  m0, m1, m3
-        pslld      m1,  4
+        pmaddubsw  m0, m1, m3 ; shift high and low samples of each dword and mask out other bits
+        pslld      m1,  4     ; shift center sample of each dword
         %if cpuflag(avx512)
-            vpternlogd m0, m1, m6, 0xd8 ; C?B:A
+            vpternlogd m0, m1, m6, 0xd8 ; C?B:A ; merge and mask out bad bits from B
         %else
             pand       m1, m6, m1
             pandn      m0, m6, m0
-- 
2.38.0



More information about the ffmpeg-devel mailing list