[FFmpeg-devel] [PATCH v2 00/31] Use av_dict_iterate where approproate

[Marvin Scholz]

Changes to v1:

- Fixed 0 used as NULL pointer in wtvenc
- Dropped change to the dict test
- Narrowed variabel scope/removed unnecessary variables
  in fftools/ffmpeg_filter.c

---

This patchset replaces the common use of:

av_dict_get(format_options, "", entry, AV_DICT_IGNORE_SUFFIX)

with the new av_dict_iterate in most places where it makes
sense. It is more concise and clearer to understand the
intention of the code.

Additionally for fftools/ffmpeg_filter it switches to
av_dict_get_string, as it makes more sense to use the
proper API for that instead of manually assembling the
string.

Marvin Scholz (31):
  fftools: use av_dict_iterate
  fftools: use av_dict_get_string
  avcodec/librav1e: use av_dict_iterate
  avcodec/librav1e: remove unnecessary variable
  avcodec/libvpxenc: use av_dict_iterate
  avformat/smjpegenc: use av_dict_iterate
  avutil: use av_dict_iterate
  avfilter/vf_scale: use av_dict_iterate
  avfilter/vf_coreimage: use av_dict_iterate
  avcodec/libxavs2: use av_dict_iterate
  avcodec/avpacket: use av_dict_iterate
  avformat/vorbiscomment: use av_dict_iterate
  avfilter/vf_libvmaf: use av_dict_iterate
  avfilter/f_metadata: use av_dict_iterate
  avformat/cafenc: use av_dict_iterate
  doc/examples/metadata: use av_dict_iterate
  avformat/movenc: use av_dict_iterate
  avformat/metadata: use av_dict_iterate
  avformat/flvenc: use av_dict_iterate
  avformat/hls: use av_dict_iterate
  avformat/lrcenc: use av_dict_iterate
  avformat/dump: use av_dict_iterate
  avformat/wtvenc: use av_dict_iterate
  avformat/ffmetaenc: use av_dict_iterate
  avformat/id3v2enc: use av_dict_iterate
  avformat/nutenc: use av_dict_iterate
  avformat/apetag: use av_dict_iterate
  avformat/asfenc: use av_dict_iterate
  avformat/http: use av_dict_iterate
  avformat/matroskaenc: use av_dict_iterate
  avformat/fifo: use av_dict_iterate

 doc/examples/metadata.c     |  2 +-
 fftools/cmdutils.c          |  2 +-
 fftools/ffmpeg.c            |  2 +-
 fftools/ffmpeg_demux.c      |  5 ++---
 fftools/ffmpeg_filter.c     | 36 +++++++++++++++---------------------
 fftools/ffmpeg_opt.c        |  2 +-
 fftools/ffplay.c            |  4 ++--
 fftools/ffprobe.c           |  6 +++---
 libavcodec/avpacket.c       |  2 +-
 libavcodec/librav1e.c       |  7 +++----
 libavcodec/libvpxenc.c      |  4 ++--
 libavcodec/libxavs2.c       |  4 ++--
 libavfilter/f_metadata.c    |  4 ++--
 libavfilter/vf_coreimage.m  | 16 ++++++++--------
 libavfilter/vf_libvmaf.c    | 10 +++++-----
 libavfilter/vf_scale.c      |  4 ++--
 libavformat/apetag.c        |  4 ++--
 libavformat/asfenc.c        |  4 ++--
 libavformat/cafenc.c        |  6 +++---
 libavformat/dump.c          |  2 +-
 libavformat/ffmetaenc.c     |  4 ++--
 libavformat/fifo.c          |  4 ++--
 libavformat/flvenc.c        |  4 ++--
 libavformat/hls.c           |  6 +++---
 libavformat/http.c          |  6 +++---
 libavformat/id3v2enc.c      | 10 +++++-----
 libavformat/lrcenc.c        |  3 +--
 libavformat/matroskaenc.c   |  2 +-
 libavformat/metadata.c      |  4 ++--
 libavformat/movenc.c        |  8 ++++----
 libavformat/nutenc.c        | 12 ++++++------
 libavformat/smjpegenc.c     |  4 ++--
 libavformat/vorbiscomment.c | 14 +++++++-------
 libavformat/wtvenc.c        |  8 ++++----
 libavutil/opt.c             | 12 ++++++------
 libavutil/tests/dict.c      |  2 +-
 36 files changed, 110 insertions(+), 119 deletions(-)

-- 
2.37.0 (Apple Git-136)