[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver

Brian Norris briannorris at chromium.org
Tue Nov 29 21:03:24 EET 2022


Hi Anton,

On Tue, Nov 29, 2022 at 12:25:11PM +0100, Anton Khirnov wrote:
> I'm not the maintainer for this, but I wonder if it wouldn't be cleaner
> to instead add something like a 'kernel_driver_blacklist' option that
> would contain a comma-separated list of ignored drivers, and default to
> 'vgem' (with maybe more added later).

I could go for a list of some kind to make this more extensible, if it's
worthwhile. But is it important to make it an "option" (as in, CLI
option presumably)? Comma-separated is especially tricky, as I believe
the existing dict/arg parsing uses commas to delimit separate key/value
pairs. I suppose I could use "+", as there's precedent in vulkan
(instance_extensions, etc.).

It also feels like "user-configurable" and "default list" are somewhat
at odds, because the default list has good reason to be there, and yet
might change underneath the user across versions (if there are new
vgem-like drivers, etc.). So any CLI user would have to keep up to date
with the defaults. I suppose maybe that's not a horrible problem; I'm
just trying to think it through, as I wouldn't personally have any need
for it if the default list is good.

Thanks for your thoughts.

Brian


More information about the ffmpeg-devel mailing list