[FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

[Timo Rothenpieler]

On 03.10.2022 01:47, Julio C. Rocha wrote:
> ---
>   configure | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 6712d045d9..f5f5eb29dd 100755
> --- a/configure
> +++ b/configure
> @@ -4847,7 +4847,12 @@ probe_cc(){
>           else
>               _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r')
>           fi
> -        _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)'
> +        if [ "$(grep -i Microsoft /proc/version)" ]; then

Not convinced that this is a good check.
I can think of a few other situations where Microsoft might appear in 
there. Like, for example on one of their servers, Azure Cloud, Github 
Actions and so on.

> +            # Windows Subsystem for Linux
> +            _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& getline pth; print "$@:", pth } }'\'' > $(@:.o=.d)'
> +        else
> +            _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)'
> +        fi
>           _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs'
>           _cflags_speed="-O2"
>           _cflags_size="-O1"


What actual issue is this solving?
I've been building in WSL for years, including MSVC builds, and never 
encountered any problems.