[FFmpeg-devel] [PATCH 2/2] avformat/mp3dec: remove a call to avio_tell()

Anton Khirnov anton at khirnov.net
Tue Oct 4 12:01:02 EEST 2022


Quoting Zhao Zhili (2022-09-25 06:28:41)
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> ---
>  libavformat/mp3dec.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
> index a9e494452d..05c13228bc 100644
> --- a/libavformat/mp3dec.c
> +++ b/libavformat/mp3dec.c
> @@ -424,15 +424,14 @@ static int mp3_read_header(AVFormatContext *s)
>          }
>      }
>      if (i == 64 * 1024) {
> -        ret = avio_seek(s->pb, off, SEEK_SET);
> +        off = avio_seek(s->pb, off, SEEK_SET);
>      } else {
>          av_log(s, i > 0 ? AV_LOG_INFO : AV_LOG_VERBOSE, "Skipping %d bytes of junk at %"PRId64".\n", i, off);
> -        ret = avio_seek(s->pb, off + i, SEEK_SET);
> +        off = avio_seek(s->pb, off + i, SEEK_SET);
>      }
> -    if (ret < 0)
> -        return ret;
> +    if (off < 0)
> +        return off;
>  
> -    off = avio_tell(s->pb);

Looks ok.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list