[FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Sun Oct 9 19:03:51 EEST 2022


Andreas Rheinhardt:
> GCC 4.0 not only added a visibility attribute, but also
> a pragma to set it for a whole region of code.*
> This commit exposes this via macros.
> 
> *: See https://gcc.gnu.org/gcc-4.0/changes.html
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavutil/attributes_internal.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavutil/attributes_internal.h b/libavutil/attributes_internal.h
> index 9d3d10b63e..3df1ee6af3 100644
> --- a/libavutil/attributes_internal.h
> +++ b/libavutil/attributes_internal.h
> @@ -23,8 +23,12 @@
>  
>  #if (AV_GCC_VERSION_AT_LEAST(4,0) || defined(__clang__)) && (defined(__ELF__) || defined(__MACH__))
>  #    define attribute_visibility_hidden __attribute__((visibility("hidden")))
> +#    define FF_VISIBILITY_PUSH_HIDDEN   _Pragma("GCC visibility push(hidden)")
> +#    define FF_VISIBILITY_POP_HIDDEN    _Pragma("GCC visibility pop")
>  #else
>  #    define attribute_visibility_hidden
> +#    define FF_VISIBILITY_PUSH_HIDDEN
> +#    define FF_VISIBILITY_POP_HIDDEN
>  #endif
>  
>  #endif /* AVUTIL_ATTRIBUTES_INTERNAL_H */

Will apply this patch and the opus patch dependening upon it tomorrow
unless there are objections.

- Andreas



More information about the ffmpeg-devel mailing list