[FFmpeg-devel] [PATCH 3/4] avcodec/svq1: Set hidden visibility

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Oct 11 16:18:47 EEST 2022


The encoder uses ff_svq1_inter_mean_vlc + 256 and setting
hidden visibility allows to bake this "+ 256" into the
general offset of ff_svq1_inter_mean_vlc and the code
accessing it.

For certain arches, this is also required for the compiler
to not produce overtly pessimistic code that can't be fixed
up by the linker lateron.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavcodec/svq1.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/svq1.h b/libavcodec/svq1.h
index af8a7dfa04..0ccf17c253 100644
--- a/libavcodec/svq1.h
+++ b/libavcodec/svq1.h
@@ -37,6 +37,8 @@
 
 #include <stdint.h>
 
+#include "libavutil/attributes_internal.h"
+
 #define SVQ1_BLOCK_SKIP         0
 #define SVQ1_BLOCK_INTER        1
 #define SVQ1_BLOCK_INTER_4V     2
@@ -49,6 +51,7 @@
 #define SVQ1_BLOCK_INTRA_CODE   0
 #define SVQ1_BLOCK_INTRA_LEN    3
 
+FF_VISIBILITY_PUSH_HIDDEN
 extern const int8_t *const ff_svq1_inter_codebooks[6];
 extern const int8_t *const ff_svq1_intra_codebooks[6];
 
@@ -59,5 +62,6 @@ extern const uint16_t ff_svq1_intra_mean_vlc[256][2];
 extern const uint16_t ff_svq1_inter_mean_vlc[512][2];
 
 extern const uint16_t ff_svq1_frame_size_table[7][2];
+FF_VISIBILITY_POP_HIDDEN
 
 #endif /* AVCODEC_SVQ1_H */
-- 
2.34.1



More information about the ffmpeg-devel mailing list