[FFmpeg-devel] [PATCH v2] lavf/async: Fix ring_write return value

Anton Khirnov anton at khirnov.net
Thu Oct 13 17:55:34 EEST 2022


Quoting Guangyu Sun (2022-09-29 20:11:34)
> his fixes a regression from commit 36117968ad.
> 
> wrapped_url_read() used to be able to return positive number from
> ffurl_read(). It relies on the result to check if EOF is reached in
> async_buffer_task().
> 
> But FIFO callbacks must return 0 on success. This should be handled
> in ring_write() instead.
> 
> Test case:
>   ffmpeg -f lavfi -i testsrc -t 1 test.mp4
>   ffmpeg -i async:test.mp4
> 
> Signed-off-by: Guangyu Sun <gsun at roblox.com>
> ---
>  libavformat/async.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Thank you, will push.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list