[FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

Michael Niedermayer michael at niedermayer.cc
Fri Oct 14 00:05:05 EEST 2022


Hi

On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote:
> codec_id is always AV_CODEC_ID_MPEG4 in this file.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>  libavcodec/mpeg4videodec.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
[...]
> @@ -3084,7 +3083,6 @@ int ff_mpeg4_workaround_bugs(AVCodecContext *avctx)
>                 ctx->divx_version, ctx->divx_build, s->divx_packed ? "p" : "");
>  
>      if (CONFIG_MPEG4_DECODER && ctx->xvid_build >= 0 &&
> -        s->codec_id == AV_CODEC_ID_MPEG4 &&

should the CONFIG_MPEG4_DECODER check be removed too ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221013/2e1ea394/attachment.sig>


More information about the ffmpeg-devel mailing list