[FFmpeg-devel] [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits

Nicolas Gaullier nicolas.gaullier at cji.paris
Fri Oct 14 11:03:18 EEST 2022


>Envoyé : mardi 13 septembre 2022 23:31

>Mantissas are the last data in the channel subsegment and it appears it is sometimes missing a very few bits for the parsing to complete.
>This should not be confused with data corruption.
>For 5.1+2 at 25fps, the occurence of this issue is pretty steady and about once every 2 hours.
>The truncation is at about 950 out of the 1024 values (never seen below 923 so far).
>The current code raises a severe 'Read past end' error and all data is lost resulting in
>20ms(@25fps) of silence for the affected channel.
>This patch introduces a tolerance: if 800 out of the 1024 mantissas have been parsed, a simple warning is raised and the data is preserved.

I did not received any feedback yet (except trivial wrap-lines warning from patchwork).
I tried to contact foobaz86 at gmail.com > 2 weeks ago, but with no answer, I fear there is nobody behind the screen.
And no activity in https://github.com/foo86 for 5 years.

Maybe MAINTAINERS should be updated ?

There are a lot of things to come as DolbyED2 support (rawly already decodable with current code) and broader avformats support,
so this is not only about this single interoperability point issue.

Thank you for your support
Nicolas


More information about the ffmpeg-devel mailing list