[FFmpeg-devel] [PATCH] fftools/ffmpeg: rename read_file() to avoid conflict with libass

Anton Khirnov anton at khirnov.net
Thu Oct 20 11:25:35 EEST 2022


Quoting Rémi Denis-Courmont (2022-10-20 10:06:45)
> `file_read` is just as likely to cause naming conflicts. And I have
> seen really insane libraries with no namespacing getting preloaded, so
> it is unfortunately not even only a problem with libraries that FFmpeg
> links with.
>
> If you're going to treat this as an FFmpeg bug... I fear that the only
> solution consists of prefixing all extern symbols for namespacing.

No, as far as I'm concerned this is libass bug and this is merely a
workaround. I don't think we should preemptively try to work around
other bugs in other libraries - they should be found and fixed there.

Apparently this is going to be fixed in libass as well, but we still
need to hanlde older versions.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list