[FFmpeg-devel] [PATCH 2/5] avcodec/aac_ac3_parser: don't fill stream info in the sync function

[James Almer]

On 10/23/2022 2:34 PM, Andreas Rheinhardt wrote:
> Michael Niedermayer:
>> On Sat, Oct 22, 2022 at 06:02:23PM -0300, James Almer wrote:
>>> Have it only find frame boundaries. The stream props will then be filled once
>>> we have an assembled frame.
>>>
>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>> ---
>>>   libavcodec/aac_ac3_parser.c | 63 +++++++++++++++++++++++++++++--------
>>>   libavcodec/aac_ac3_parser.h | 12 +------
>>>   libavcodec/aac_parser.c     |  7 +----
>>>   libavcodec/ac3_parser.c     | 16 +---------
>>>   4 files changed, 53 insertions(+), 45 deletions(-)
>>
>> i probably forgot something but this breaks:
>>
>> --- ./tests/ref/fate/adtstoasc_ticket3715	2022-10-22 10:37:36.046518037 +0200
>> +++ tests/data/fate/adtstoasc_ticket3715	2022-10-23 17:32:17.096459090 +0200
>> @@ -1,4 +1,4 @@
>> -29ef0632a8eb5c336bf45a1d5076626e *tests/data/fate/adtstoasc_ticket3715.mov
>> +4110be924e21846d0e174fac679b062e *tests/data/fate/adtstoasc_ticket3715.mov
>>   33324 tests/data/fate/adtstoasc_ticket3715.mov
>>   #extradata 0:        2, 0x00340022
>>   #tb 0: 1/44100
>> Test adtstoasc_ticket3715 failed. Look at tests/data/fate/adtstoasc_ticket3715.err for details.
>> tests/Makefile:306: recipe for target 'fate-adtstoasc_ticket3715' failed
>> make: *** [fate-adtstoasc_ticket3715] Error 1
>>
>> [...]
>>
> 
> You are not alone: Same thing happened with patchwork.

Yes, i noticed and fixed it last night, but didn't send the patch for it 
since it was late. Will do it in a bit.

> 
> - Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".