[FFmpeg-devel] [PATCH 09/11] avfilter/overlay_vaapi: enable expressions for overlay parameters

Soft Works softworkz at hotmail.com
Mon Oct 31 07:56:14 EET 2022



> -----Original Message-----
> From: Xiang, Haihao <haihao.xiang at intel.com>
> Sent: Monday, October 31, 2022 6:44 AM
> To: ffmpeg-devel at ffmpeg.org
> Cc: softworkz at hotmail.com
> Subject: Re: [FFmpeg-devel] [PATCH 09/11] avfilter/overlay_vaapi:
> enable expressions for overlay parameters
> 
> On Mon, 2022-10-10 at 10:54 +0000, softworkz wrote:
> > From: softworkz <softworkz at hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  libavfilter/vf_overlay_vaapi.c | 141
> +++++++++++++++++++++++++++++----
> >  1 file changed, 127 insertions(+), 14 deletions(-)
> >
> > diff --git a/libavfilter/vf_overlay_vaapi.c
> b/libavfilter/vf_overlay_vaapi.c
> > index b2c254d9dd..7be7d52589 100644
> > --- a/libavfilter/vf_overlay_vaapi.c
> > +++ b/libavfilter/vf_overlay_vaapi.c
> > @@ -27,19 +27,106 @@
> >  #include "formats.h"
> >  #include "internal.h"
> >  #include "vaapi_vpp.h"
> > +#include "libavutil/eval.h"
> > +
> > +enum var_name {
> > +    VAR_MAIN_iW,     VAR_MW,
> > +    VAR_MAIN_iH,     VAR_MH,
> > +    VAR_OVERLAY_iW,
> > +    VAR_OVERLAY_iH,
> 
> It is better not to mix capital and lower-case letters here, (I have
> a patch to
> change the var_name in qsv)

Yea - I had done it equal to overlay_qsv.
I'll change it, no problem.

Thanks,
softworkz


More information about the ffmpeg-devel mailing list