[FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add JPEG 2000 test

[Andreas Rheinhardt]

Pierre-Anthony Lemieux:
> On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt
> <andreas.rheinhardt at outlook.com> wrote:
>>
>> pal at sandflow.com:
>>> From: Pierre-Anthony Lemieux <pal at palemieux.com>
>>>
>>> ---
>>>  tests/fate/mxf.mak           |  4 ++
>>>  tests/ref/fate/mxf-probe-j2k | 78 ++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 82 insertions(+)
>>>  create mode 100644 tests/ref/fate/mxf-probe-j2k
>>>
>>> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
>>> index 3ab936b5de..38d1c2ef38 100644
>>> --- a/tests/fate/mxf.mak
>>> +++ b/tests/fate/mxf.mak
>>> @@ -29,6 +29,10 @@ FATE_MXF_PROBE-$(call ENCDEC, DNXHD, MXF) += fate-mxf-probe-dnxhd
>>>  fate-mxf-probe-dnxhd: SRC = $(TARGET_SAMPLES)/mxf/multiple_components.mxf
>>>  fate-mxf-probe-dnxhd: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
>>>
>>> +FATE_MXF_PROBE-$(call ENCDEC, JPEG2000, MXF) += fate-mxf-probe-j2k
>>
>> ENCDEC? Since when does ffprobe run encoders at all?
> 
> I did wonder, but ended-up using the same template as fate-mxf-probe-dnxhd.
> 
> Should they all be changed to DEC?
> 

I have not looked at these tests in particular, but DEMDEC is the
expected command here. Notice that there might be scenarios where you
need more (like an additional parser or the extract extradata bsf (I
expect the mxf-probe-d10 test to need the latter and maybe the former in
addition to the mpeg2video decoder.)).

>>
>>> +fate-mxf-probe-j2k: SRC = $(TARGET_SAMPLES)/imf/countdown/countdown-small.mxf
>>> +fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
>>> +
>>>  FATE_MXF_PROBE-$(call ENCDEC2, DVVIDEO, PCM_S16LE, MXF) += fate-mxf-probe-dv25
>>>  fate-mxf-probe-dv25: SRC = $(TARGET_SAMPLES)/mxf/Avid-00005.mxf
>>>  fate-mxf-probe-dv25: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
>>> diff --git a/tests/ref/fate/mxf-probe-j2k b/tests/ref/fate/mxf-probe-j2k
>>> new file mode 100644
>>> index 0000000000..2dbf2ac37d
>>> --- /dev/null
>>> +++ b/tests/ref/fate/mxf-probe-j2k
>>> @@ -0,0 +1,78 @@
>>> +[STREAM]
>>> +index=0
>>> +codec_name=jpeg2000
>>> +profile=1798
>>> +codec_type=video
>>> +codec_tag_string=[0][0][0][0]
>>> +codec_tag=0x0000
>>> +width=640
>>> +height=360
>>> +coded_width=640
>>> +coded_height=360
>>> +closed_captions=0
>>> +film_grain=0
>>> +has_b_frames=0
>>> +sample_aspect_ratio=1:1
>>> +display_aspect_ratio=16:9
>>> +pix_fmt=rgb48le
>>> +level=-99
>>> +color_range=unknown
>>> +color_space=unknown
>>> +color_transfer=bt709
>>> +color_primaries=bt709
>>> +chroma_location=unspecified
>>> +field_order=progressive
>>> +refs=1
>>> +id=N/A
>>> +r_frame_rate=24/1
>>> +avg_frame_rate=24/1
>>> +time_base=1/24
>>> +start_pts=0
>>> +start_time=0.000000
>>> +duration_ts=24
>>> +duration=1.000000
>>> +bit_rate=N/A
>>> +max_bit_rate=N/A
>>> +bits_per_raw_sample=16
>>> +nb_frames=N/A
>>> +nb_read_frames=N/A
>>> +nb_read_packets=N/A
>>> +DISPOSITION:default=0
>>> +DISPOSITION:dub=0
>>> +DISPOSITION:original=0
>>> +DISPOSITION:comment=0
>>> +DISPOSITION:lyrics=0
>>> +DISPOSITION:karaoke=0
>>> +DISPOSITION:forced=0
>>> +DISPOSITION:hearing_impaired=0
>>> +DISPOSITION:visual_impaired=0
>>> +DISPOSITION:clean_effects=0
>>> +DISPOSITION:attached_pic=0
>>> +DISPOSITION:timed_thumbnails=0
>>> +DISPOSITION:captions=0
>>> +DISPOSITION:descriptions=0
>>> +DISPOSITION:metadata=0
>>> +DISPOSITION:dependent=0
>>> +DISPOSITION:still_image=0
>>> +TAG:file_package_umid=0x060A2B340101010501010F201300000035E05073878E4B2FB69D2369F25ADFC9
>>> +TAG:file_package_name=File Package: SMPTE ST 422 / ST 2067-5 frame wrapping of JPEG 2000 codestreams
>>> +TAG:track_name=Image Track
>>> +[/STREAM]
>>> +[FORMAT]
>>> +format_name=mxf
>>> +duration=1.000000
>>> +bit_rate=577792
>>> +TAG:operational_pattern_ul=060e2b34.04010101.0d010201.01010100
>>> +TAG:uid=f1994e51-a844-49e4-9459-1ddd622eb65d
>>> +TAG:generation_uid=1be151ac-cc95-4314-b09f-7420eda9932b
>>> +TAG:company_name=Sandflow Consulting LLC
>>> +TAG:product_name=dcdm2imf
>>> +TAG:product_version_num=0.0.0.0.0
>>> +TAG:product_version=1.0-beta1
>>> +TAG:product_uid=927fc4d1-89a3-4f88-88bb-d363ed33084a
>>> +TAG:modification_date=2022-01-07T22:05:01.000000Z
>>> +TAG:toolkit_version_num=2.10.38.27240.1
>>> +TAG:application_platform=win32
>>> +TAG:material_package_umid=0x060A2B340101010501010F201300000072BAF0557DA749308C14738BCD4FA116
>>> +TAG:material_package_name=Material Package
>>> +[/FORMAT]
>>