[FFmpeg-devel] [PATCH] avocdec/flac_parser: another fix

[Paul B Mahol]

On Wed, Sep 7, 2022 at 12:31 PM Mattias Wadman <mattias.wadman at gmail.com>
wrote:

> On Mon, Sep 5, 2022 at 8:16 PM Paul B Mahol <onemda at gmail.com> wrote:
>
> > Patch attached.
> >
>
> Thanks and can confirm that the patch produces the same samples as the flac
> reference decoder for the original file in
> https://trac.ffmpeg.org/ticket/9621 that I could not share.
>
> But I'm not sure I follow how the patch works. I read it as we skip
> checking CRC if the current frame or sample number is the expected next
> one?
>

It always force CRC check if they do not match, previously code would do
that sometimes.


>
> +    if ((fpc->last_fi.frame_or_sample_num + 1 ==
> header_fi->frame_or_sample_num) ||
> +        (fpc->last_fi.frame_or_sample_num + fpc->last_fi.blocksize ==
> header_fi->frame_or_sample_num)) {
>
> Would it make sense to look at the blocking strategy bit to know which one
> to check?
>

 Could be.

_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>