[FFmpeg-devel] [PATCH] avcodec/dolby_e: Add error recovery when parse_mantissas run out of bits

Nicolas Gaullier nicolas.gaullier at cji.paris
Fri Sep 16 11:28:44 EEST 2022


>Envoyé : mardi 13 septembre 2022 23:31
>Mantissas are the last data in the channel subsegment and it appears it is sometimes missing a very few bits for the parsing to complete.
>This should not be confused with data corruption.

Here is a very short sample set with an audacity screen grab which shows the effect of the fix:
http://0x0.st/oOvv.zip

I don't know how to make this patch acceptable... and especially I understand that setting an arbitrary limit with a #define does not look to be the best practice in the world.
The fact is that the reference implementation (checked against dp600 and a certified broadcast encoder) does handle that (maybe with no limit at all, hard to tell).
Do you have any suggestion ?
If it can help, I can post a message to ffmpeg-user to gain more users support ?

Nicolas


More information about the ffmpeg-devel mailing list