[FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

[Pierre-Anthony Lemieux]

On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal at sandflow.com wrote:
> > From: Pierre-Anthony Lemieux <pal at palemieux.com>
> >
> > Addresses coverity 1512414
> >
> > ---
> >  libavformat/imfdec.c | 15 ++++++++++++---
> >  1 file changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > index 5bbe7a53f8..58b1455c9f 100644
> > --- a/libavformat/imfdec.c
> > +++ b/libavformat/imfdec.c
> > @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma
> >  {
> >      IMFContext *c = s->priv_data;
> >      IMFVirtualTrackPlaybackCtx *track;
>
> > +    AVRational minimum_timestamp = av_make_q(INT_MAX, 1);
> > -    AVRational minimum_timestamp = av_make_q(INT32_MAX, 1);
>
> iam not sure thats a good idea, it would change behavior on different platforms

I was following the earlier observations that "The initialization of
minimum_timestamp presumes that int are 32bit which need not be true":

http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300587.html

If I am not mistaken, the numerator and denominator of AVRational are
defined as `int`:

https://www.ffmpeg.org/doxygen/trunk/structAVRational.html

What would be the alternative?

>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> it is not once nor twice but times without number that the same ideas make
> their appearance in the world. -- Aristotle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".