[FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use

Paul B Mahol onemda at gmail.com
Sat Sep 17 17:45:28 EEST 2022


On 9/17/22, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in
> type 'int'
> Fixes:
> 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/aiffdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
> index 318e3ad742e..80733e58010 100644
> --- a/libavformat/aiffdec.c
> +++ b/libavformat/aiffdec.c
> @@ -428,7 +428,7 @@ static int aiff_read_packet(AVFormatContext *s,
>          pkt->flags &= ~AV_PKT_FLAG_CORRUPT;
>      /* Only one stream in an AIFF file */
>      pkt->stream_index = 0;
> -    pkt->duration     = (res / st->codecpar->block_align) *
> aiff->block_duration;
> +    pkt->duration     = (res / st->codecpar->block_align) * (int64_t)
> aiff->block_duration;
>      return 0;
>  }

LGTM

>
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>


More information about the ffmpeg-devel mailing list