[FFmpeg-devel] [PATCH v4 0/6] Add display_matrix option

Thilo Borgmann thilo.borgmann at mail.de
Mon Sep 19 12:45:58 EEST 2022


Hi,

this is an updated and cleaned-up version of Jan's patchset discussed in [1], now v4...
I'd especially appreciate any comments on 5/6, ffmpeg_opt.c:119ff which is pretty ugly as-is.

Previous reviews were split between threads [2][3] and are merged into.
Now it comes with cover letter as the topic would have changed again, keep track of revision and notget reviews on the same stuff in seperate threads.

Should fix #8329 and #6370.

Thanks,
Thilo

[1] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296553.html
[2] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300076.html
[3] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300122.html

Jan Ekström (3):
  fftools: Add support for dictionary options
  ffmpeg: Add display_matrix option
  ffmpeg: Deprecate display rotation override with a metadata key

Thilo Borgmann (3):
  lavu/opt: Allow options to be arguments of other options
  fftools/cmdutils: Print arguments of options
  lavu/display: Add horizontal and vertical scaling to the display
    matrix

 doc/APIchanges              |   7 ++
 doc/ffmpeg.texi             |  18 ++++
 fftools/cmdutils.c          |  22 +++++
 fftools/cmdutils.h          |   3 +
 fftools/ffmpeg.c            |   2 +
 fftools/ffmpeg.h            |   7 ++
 fftools/ffmpeg_filter.c     |  13 +++
 fftools/ffmpeg_opt.c        | 162 +++++++++++++++++++++++++++++++++++-
 libavutil/display.c         |  35 ++++++++
 libavutil/display.h         |  26 ++++++
 libavutil/opt.c             |  14 +++-
 libavutil/opt.h             |   8 ++
 libavutil/version.h         |   4 +-
 tests/fate/filter-video.mak |   2 +-
 14 files changed, 316 insertions(+), 7 deletions(-)

-- 
2.20.1 (Apple Git-117)



More information about the ffmpeg-devel mailing list