[FFmpeg-devel] [PATCHv2 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

Rémi Denis-Courmont remi at remlab.net
Mon Sep 19 19:06:45 EEST 2022


Le maanantaina 19. syyskuuta 2022, 18.48.11 EEST James Almer a écrit :
> On 9/19/2022 12:35 PM, remi at remlab.net wrote:
> > From: Rémi Denis-Courmont <remi at remlab.net>
> > 
> > While this probably never overflows, we are better safe than sorry.
> > 
> > The callback prototype should probably also use ptrdiff_t or size_t,
> > but I diggress (this would affect the DSP callback prototype).
> 
> If you mean using ptrdiff_t instead of intptr_t, it should be pretty
> straightforward. Effectively only a prototype change and no need to
> touch the asm implementations. It would also put it in line with the
> rest of the codebase.

Unfortunately, they are defined in different headers, <stddef.h> vs <stdint.h> 
so it is not quite that straightforward.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the ffmpeg-devel mailing list