[FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index()

Tomas Härdin tjoppen at acc.umu.se
Tue Sep 20 14:12:44 EEST 2022


sön 2022-09-11 klockan 16:27 +0200 skrev Michael Niedermayer:
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/mxfdec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index e63e803aa56..4ceb6cf672f 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1939,10 +1939,10 @@ static int
> mxf_compute_ptses_fake_index(MXFContext *mxf, MXFIndexTable *index_ta
>      if (index_table->nb_ptses <= 0)
>          return 0;
>  
> -    if (!(index_table->ptses      = av_calloc(index_table->nb_ptses,
> sizeof(int64_t))) ||
> +    if (!(index_table->ptses      = av_malloc_array(index_table-
> >nb_ptses, sizeof(int64_t))) ||
>          !(index_table->fake_index = av_calloc(index_table->nb_ptses,
> sizeof(AVIndexEntry))) ||
>          !(index_table->offsets    = av_calloc(index_table->nb_ptses,
> sizeof(int8_t))) ||
> -        !(flags                   = av_calloc(index_table->nb_ptses,
> sizeof(uint8_t)))) {
> +        !(flags                   = av_malloc_array(index_table-
> >nb_ptses, sizeof(uint8_t)))) {

Looks OK. Seems like the same thing can be done with offsets

/Tomas



More information about the ffmpeg-devel mailing list