[FFmpeg-devel] [PATCH 2/2] avutil/dict: Use av_dict_iterate in av_dict_get

Marvin Scholz epirat07 at gmail.com
Thu Sep 22 05:02:16 EEST 2022


---
 libavutil/dict.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/libavutil/dict.c b/libavutil/dict.c
index 2f690a5b8e..1a348d6710 100644
--- a/libavutil/dict.c
+++ b/libavutil/dict.c
@@ -60,18 +60,14 @@ AVDictionaryEntry *av_dict_iterate(const AVDictionary *m,
 AVDictionaryEntry *av_dict_get(const AVDictionary *m, const char *key,
                                const AVDictionaryEntry *prev, int flags)
 {
-    unsigned int i, j;
+    AVDictionaryEntry *entry = (AVDictionaryEntry *)prev;
+    unsigned int j;
 
-    if (!m || !key)
+    if (!key)
         return NULL;
 
-    if (prev)
-        i = prev - m->elems + 1;
-    else
-        i = 0;
-
-    for (; i < m->count; i++) {
-        const char *s = m->elems[i].key;
+    while (entry = av_dict_iterate(m, entry)) {
+        const char *s = entry->key;
         if (flags & AV_DICT_MATCH_CASE)
             for (j = 0; s[j] == key[j] && key[j]; j++)
                 ;
@@ -82,7 +78,7 @@ AVDictionaryEntry *av_dict_get(const AVDictionary *m, const char *key,
             continue;
         if (s[j] && !(flags & AV_DICT_IGNORE_SUFFIX))
             continue;
-        return &m->elems[i];
+        return entry;
     }
     return NULL;
 }
-- 
2.37.0 (Apple Git-136)



More information about the ffmpeg-devel mailing list