[FFmpeg-devel] [PATCH] avcodec/mjpegdec: fix -Wparentheses warning

[Rémi Denis-Courmont]

Le perjantaina 23. syyskuuta 2022, 20.40.30 EEST Zhao Zhili a écrit :
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> Signed-off-by: Zhao Zhili <zhilizhao at tencent.com>
> ---
>  libavcodec/mjpegdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
> index c594950500..d77c644d3b 100644
> --- a/libavcodec/mjpegdec.c
> +++ b/libavcodec/mjpegdec.c
> @@ -2866,7 +2866,7 @@ the_end:
>          }
>      }
> 
> -    if (e = av_dict_get(s->exif_metadata, "Orientation", e,
> AV_DICT_IGNORE_SUFFIX)) { +    if ((e = av_dict_get(s->exif_metadata,
> "Orientation", e, AV_DICT_IGNORE_SUFFIX))) { char *value = e->value +
> strspn(e->value, " \n\t\r"), *endptr; int orientation = strtol(value,
> &endptr, 0);

Isn't it easier to read if you break the assignment out, and use the result as 
predicate??

-- 
レミ・デニ-クールモン
http://www.remlab.net/