[FFmpeg-devel] [PATCH v3 24/54] swscale: Fix bogus doxy comment #ifdefs

Marvin Scholz epirat07 at gmail.com
Sun Sep 25 03:10:51 EEST 2022


The intention here was probably to document this as use of
conditionals does not make sense in a comment.

Fixes doxy warning:
  warning: explicit link request to 'if' could not be resolved
---
 libswscale/swscale.h | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/libswscale/swscale.h b/libswscale/swscale.h
index 3ebf7c698d..9794f6a258 100644
--- a/libswscale/swscale.h
+++ b/libswscale/swscale.h
@@ -324,22 +324,17 @@ unsigned int sws_receive_slice_alignment(const struct SwsContext *c);
  * @param brightness 16.16 fixed point brightness correction
  * @param contrast 16.16 fixed point contrast correction
  * @param saturation 16.16 fixed point saturation correction
-#if LIBSWSCALE_VERSION_MAJOR > 6
- * @return negative error code on error, non negative otherwise
-#else
- * @return -1 if not supported
-#endif
+ *
+ * @return A negative error code on error, non negative otherwise.
+ *         If `LIBSWSCALE_VERSION_MAJOR < 7`, returns -1 if not supported.
  */
 int sws_setColorspaceDetails(struct SwsContext *c, const int inv_table[4],
                              int srcRange, const int table[4], int dstRange,
                              int brightness, int contrast, int saturation);
 
 /**
-#if LIBSWSCALE_VERSION_MAJOR > 6
- * @return negative error code on error, non negative otherwise
-#else
- * @return -1 if not supported
-#endif
+ * @return A negative error code on error, non negative otherwise.
+ *         If `LIBSWSCALE_VERSION_MAJOR < 7`, returns -1 if not supported.
  */
 int sws_getColorspaceDetails(struct SwsContext *c, int **inv_table,
                              int *srcRange, int **table, int *dstRange,
-- 
2.37.0 (Apple Git-136)



More information about the ffmpeg-devel mailing list