[FFmpeg-devel] [PATCHv5 00/31] RISC-V CPU extensions

[Rémi Denis-Courmont]

Le 26 septembre 2022 10:05:23 GMT+03:00, Lynne <dev at lynne.ee> a écrit :
>Sep 25, 2022, 16:25 by remi at remlab.net:
>
>> Hello,
>>
>> Changes since version version 5:
>> - Use shifted-add instructions where applicable (pointer arithmetic) to
>>  minimise scalar operations to the absolute minimum.
>> - Add AAC PS DSP stereo interpolation [0].
>>
>> The following changes since commit 7cd252ee41ddc693fa140c5b5eb472b6d6f27f9e:
>>
>>  avcodec/parser: Remove declaration of inexistent function (2022-09-24 20:25:19 +0200)
>>
>> are available in the Git repository at:
>>
>>  https://git.remlab.net/git/ffmpeg.git rv-cpu
>>
>> for you to fetch changes up to 2f7afca1e160b3bb1bc761ac3eb5e08a0852120b:
>>
>>  lavc/aacpsdsp: RISC-V V stereo_interpolate[0] (2022-09-25 17:19:09 +0300)
>>
>
>Took a look at the patchset, apart from those 2 minor nits,
>it looks good to me. I can fix the branching before pushing
>if you think it'd be okay. As for the name, if they really have
>no alternative names, I'd be fine with RV_Zve64x... hunter2.

If we lift the nested CPU flags test up, then we can drop the whole forced flags thing, and moot the NULL logger argument.

Anyway, I think I can improve the AAC PS stereo interleave code, so I'll send another patchset version soonish.