[FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources

Chema Gonzalez chema at berkeley.edu
Wed Sep 28 19:20:22 EEST 2022


Hi,

On Wed, Sep 28, 2022 at 8:09 AM Anton Khirnov <anton at khirnov.net> wrote:
> >      if (isBayer(srcFormat)) {
> > +        c->dst_slice_align = 2;
>
> IMO it's better to put this next to the line that sets dst_slice_align
> for non-bayer cases, makes it clearer what the final value is.
Are you suggesting setting `dst_slice_align` in a different function?

The way I read `ff_get_unscaled_swscale()` is that it goes through the
quirks of all the different conversions (per source and destination
type). In all cases, it sets the `convert_unscaled` function pointer.
In the cases where there is the need to align (yuv2bgr and
yuv410p_to_yuv[a]420p), it also adds `dst_slice_align`. In the same
fashion, the conversions that affect Bayer sources are set in line
2097.

Thanks,
-Chema


More information about the ffmpeg-devel mailing list