[FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking
Michael Niedermayer
michael at niedermayer.cc
Fri Sep 30 01:03:25 EEST 2022
On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote:
> On Sun, Sep 18, 2022 at 01:21:23PM +0000, Paul B Mahol wrote:
> > ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Sat Sep 17 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | committer: Paul B Mahol
> >
> > avcodec/mlpdec: relax channels checking
> >
> > Internal TrueHD decoder channel rematrix can mix 2 stereo substreams
> > into single mono stream.
> >
> > Fixes #1726
> >
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=adaa06581c5444c94eef72d61b8166f096e2687a
> > ---
> >
> > libavcodec/mlpdec.c | 23 +----------------------
> > 1 file changed, 1 insertion(+), 22 deletions(-)
>
> This produces out of array accesses
>
> Also this was never posted to the mailing list. Simply removing checks is not
> a solution, how can that even be a solution ?!
>
> please make sure you post all patches especially ones thats have not been tested
> very well to the mailing list
I see it was posted to the ML, iam sorry it seems i must have missed it somehow
its still buggy though
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
"Nothing to hide" only works if the folks in power share the values of
you and everyone you know entirely and always will -- Tom Scott
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220930/42492cd5/attachment.sig>
More information about the ffmpeg-devel
mailing list