[FFmpeg-devel] [PATCH v2 06/12] avutil/frame: add helper for getting side data from set

[Anton Khirnov]

Quoting Jan Ekström (2023-04-11 23:20:46)
> ---
>  libavutil/frame.c | 22 +++++++++++++++++-----
>  libavutil/frame.h | 10 ++++++++++
>  2 files changed, 27 insertions(+), 5 deletions(-)
> 
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index 29e9b631f8..3386cda627 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -720,16 +720,28 @@ AVFrameSideData *av_new_side_data_to_set(AVFrameSideDataSet *set,
>      return ret;
>  }
>  
> -AVFrameSideData *av_frame_get_side_data(const AVFrame *frame,
> -                                        enum AVFrameSideDataType type)
> +AVFrameSideData *av_get_side_data_from_set(const AVFrameSideDataSet set,

I suppose it does not matter much because it is const, but it seem a bit
strange that you're passing in the struct itself and not a pointer.

Otherwise, the same naming complaint as for the other patches.

-- 
Anton Khirnov