[FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc

[Michael Niedermayer]

On Mon, Apr 17, 2023 at 12:36:26PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2023-04-17 00:25:16)
> > Fixes: memleak
> > Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6674082962997248
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/mov.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index 057fd872b10..6853bb324cf 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -7777,7 +7777,7 @@ static int mov_read_iloc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> >          return 0;
> >      }
> >  
> > -    if (c->fc->nb_streams) {
> > +    if (c->fc->nb_streams || c->avif_info) {
> 
> This first condition is now redundant, is it not?

Iam not sure
what exactly happens if a trak occurs before 

Iam also not sure what happens if multiple meta tags occur triggering
the avif stream addition, i may be missing something but the code seems
not to expect that

Adding the author of this code to CC

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230418/92c9ded3/attachment.sig>