[FFmpeg-devel] [PATCH 1/3] lavf/dv: do not set video timebase more than once

[Michael Niedermayer]

On Mon, Apr 24, 2023 at 05:55:51PM +0200, Anton Khirnov wrote:
> Current code will call avpriv_set_pts_info() for each video frame,
> possibly setting a different timebase if the stream framerate changes.
> This violates API conventions, as the timebase is supposed to stay
> constant after stream creation.
> 
> Change the demuxer to set a single timebase that is fine enough to
> handle all supported DV framerates.
> 
> The seek tests change slightly because the new timebase is more
> granular.
> ---
>  libavcodec/dv.h                   |  3 +++
>  libavformat/dv.c                  | 25 ++++++++++++++++++++-----
>  tests/ref/seek/lavf-dv            | 16 ++++++++--------
>  tests/ref/seek/vsynth_lena-dv     | 24 ++++++++++++------------
>  tests/ref/seek/vsynth_lena-dv-411 | 24 ++++++++++++------------
>  tests/ref/seek/vsynth_lena-dv-50  | 24 ++++++++++++------------
>  6 files changed, 67 insertions(+), 49 deletions(-)

This breaks:

./ffmpeg -ss 4:56 -i ~/tickets/4086/Oca-Agu\ 1995.avi -codec copy -t 1 -bitexact 4086-30frames.dv
(the file is empty after the patch)

The file seems no longer available on the original link and a little big
ill put it in your home directory on the server probably in 30+min or so.
once you are done with it please delete it off the server so it doesnt eat
diskspace

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20230426/49c9a144/attachment.sig>