[FFmpeg-devel] [PATCH 1/2] avformat/imf: fix invalid resource handling

[Anton Khirnov]

Quoting pal at sandflow.com (2023-04-26 19:53:01)
> From: Pierre-Anthony Lemieux <pal at palemieux.com>
> 
> ---
>  libavformat/imf_cpl.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index ad84a68b13..a7cf5fa360 100644
> --- a/libavformat/imf_cpl.c
> +++ b/libavformat/imf_cpl.c
> @@ -608,11 +608,10 @@ static int push_main_audio_sequence(xmlNodePtr audio_sequence_elem, FFIMFCPL *cp
>          ret = fill_trackfile_resource(resource_elem,
>                                        &vt->resources[vt->resource_count],
>                                        cpl);
> -        vt->resource_count++;
> -        if (ret) {
> +        if (ret)
>              av_log(NULL, AV_LOG_ERROR, "Invalid Resource\n");
> -            continue;

Should an error here not propagate to the caller?

Unrelated, but all this logging to NULL is very evil.

-- 
Anton Khirnov