[FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer

[Anton Khirnov]

Quoting SuperFashi (2023-04-30 05:32:46)
> Thanks. Is there anything else that does not fit codebase tradition? Please
> point everything out so I could send a new patch.

Some quick notes:
* why are there avpriv_ functions when everything you do is libavformat?
  avpriv is for sharing functions across libraries
* header order (first system, then ours, sort each of those
  alphabetically)
* opening brace for function declarations should be on its own line
* very long lines everywhere; we have a soft limit of 80 characters (can
  be exceeded where really needed, but should be done sparingly)
  if your code needs more then it's a sign that you have too much
  indentation or your names are too long
* inline specifiers all over the place, I think modern compilers largely
  ignore them; even if they didn't it's better to leave such decisions
  to compilers in most cases

-- 
Anton Khirnov