[FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program()

Stefano Sabatini stefasab at gmail.com
Wed Aug 2 08:32:28 EEST 2023


On date Saturday 2023-07-15 12:46:10 +0200, Anton Khirnov wrote:
> Inline the relevant part of ffprobe_cleanup() into main() and drop the
> rest.
> ---
>  fftools/ffprobe.c | 22 ++++++++--------------
>  1 file changed, 8 insertions(+), 14 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index e234c92904..a39185f6fe 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -381,17 +381,6 @@ static void log_callback(void *ptr, int level, const char *fmt, va_list vl)
>  #endif
>  }
>  
> -static void ffprobe_cleanup(int ret)
> -{

> -    int i;
> -    for (i = 0; i < FF_ARRAY_ELEMS(sections); i++)
> -        av_dict_free(&(sections[i].entries_to_show));
> -

Was this part discarded? This is mostly needed to avoid valgrind
warnings.

LGTM otherwise.



More information about the ffmpeg-devel mailing list