[FFmpeg-devel] [PATCH] libswresample: Prevent out of bounds.
kobrineli
kobrineli at ispras.ru
Wed Aug 2 15:14:10 EEST 2023
From: Eli Kobrin <kobrineli at ispras.ru>
We've been fuzzing torchvision with [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz)
and found out of bounds error in ffmpeg project at audioconvert.c:151.
To prevent error we need to fix checks for in and out fmt in swr_init.
Signed-off-by: Eli Kobrin <kobrineli at ispras.ru>
---
libswresample/swresample.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libswresample/swresample.c b/libswresample/swresample.c
index 6dc329a9d0..fb3d7bccbf 100644
--- a/libswresample/swresample.c
+++ b/libswresample/swresample.c
@@ -196,11 +196,11 @@ av_cold int swr_init(struct SwrContext *s){
clear_context(s);
- if(s-> in_sample_fmt >= AV_SAMPLE_FMT_NB){
+ if((unsigned) s-> in_sample_fmt >= AV_SAMPLE_FMT_NB){
av_log(s, AV_LOG_ERROR, "Requested input sample format %d is invalid\n", s->in_sample_fmt);
return AVERROR(EINVAL);
}
- if(s->out_sample_fmt >= AV_SAMPLE_FMT_NB){
+ if((unsigned) s->out_sample_fmt >= AV_SAMPLE_FMT_NB){
av_log(s, AV_LOG_ERROR, "Requested output sample format %d is invalid\n", s->out_sample_fmt);
return AVERROR(EINVAL);
}
--
2.25.1
More information about the ffmpeg-devel
mailing list